Conversation
Similar to `issue close`, but for deleting an issue rather than just closing it. Resolves cli#2820.
|
Hm when I run the test suite locally, I get the same failures on |
vilmibm
left a comment
There was a problem hiding this comment.
In general we prefer PRs for things with a help-wanted label, but in this case we're into the feature so we can see it through 👍
This is a solid PR! We'd like a confirmation step, though, since issue deletion is irreversible.
When this command is run attached to a terminal, please add a confirmation step like the following:
You're going to delete issue #1234. This action cannot be reversed. To confirm, type the issue number:
I'm also curious what the behavior is if a user that is not an admin attempts to delete an issue?
thanks!
Ah makes sense, will check for that in the future
@vilmibm If the command is run in a non-interactive context, would you prefer it just skip the confirmation step or throw an error? |
And regarding this, it outputs |
vilmibm
left a comment
There was a problem hiding this comment.
the prompt looks great! The logic for prompting just needs tweaking and otherwise this is just about ready. Thanks!
vilmibm
left a comment
There was a problem hiding this comment.
tested locally and it looks great! thank you!!
| IssueID: issue.ID, | ||
| }, | ||
| } | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Similar to
issue close, but for deleting an issue rather thanjust closing it.
Resolves #2820.