Add ability to view comments with pr view#2575
Merged
Conversation
69a9a33 to
9f101ff
Compare
mislav
suggested changes
Dec 9, 2020
Contributor
mislav
left a comment
There was a problem hiding this comment.
This looks good! Thanks for getting it done so quickly.
Since comments are presented identically to those in issue view, for the sake of maintainability, I definitely say that both issue view and pr view should import a shared package that provides this functionality. That way, we can tweak comments rendering in a single location.
Contributor
Author
|
@mislav I made the requested changes, if you wouldn't mind taking another look 🙇 |
|
I think that somewhere in this PR the newline at the end of the output of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to view issue comments in
gh pr view. The PR is not actually as long as the line count suggests, it is mostly due to test fixtures. There were not any major design or technical choices here as most were discussed and decided upon in #2462. This is mostly just copying logic and functionality fromgh issue viewintogh pr view. There is quite a bit of duplicate comment viewing code fromgh issue view. It would be nice to come up with a pattern to share this code.cc #1009