Skip to content

Update confusing prompt#2214

Closed
ShubhankarKG wants to merge 1 commit intocli:trunkfrom
ShubhankarKG:bugRepoCreate
Closed

Update confusing prompt#2214
ShubhankarKG wants to merge 1 commit intocli:trunkfrom
ShubhankarKG:bugRepoCreate

Conversation

@ShubhankarKG
Copy link
Contributor

Fixes #1913 , #2180

Updates the final confirmation string to reflect what we wanted it to be, a confirmation step before submitting to Github. The create a local directory now works in sync as in

  1. Pass the confirmation to create the repo on Github
  2. Ask for creating a local directory if not already.

Copy link

@Cudak96 Cudak96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a step in the right direction, but I don't think that it fully clarifies what will happen next. When ran outside of a git directory, it should say that a repo will be created and a new directory made for the new repo. When ran inside of a git directory, it should say that an origin git remote will be added.

Our team is also giving this a thought, so you could either proceed on your own or wait until we have more guidance on how we want to address this command.

@ShubhankarKG
Copy link
Contributor Author

No worries, let's wait a little longer. :)

@vilmibm vilmibm self-assigned this Jan 19, 2021
@vilmibm
Copy link
Contributor

vilmibm commented Jan 20, 2021

thank you for this! i'm going to close in favor of #2295 since while prompt absolutely does need rewording, we also need to do a series of other fixes to repo create and can address them via the larger PR.

@vilmibm vilmibm closed this Jan 20, 2021
@vilmibm vilmibm removed their assignment Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing prompt for creating repos

5 participants