Skip to content

gh repo create improvements#2295

Closed
ephelsa wants to merge 2 commits intocli:trunkfrom
ephelsa:improve-repo-create
Closed

gh repo create improvements#2295
ephelsa wants to merge 2 commits intocli:trunkfrom
ephelsa:improve-repo-create

Conversation

@ephelsa
Copy link

@ephelsa ephelsa commented Oct 26, 2020

Summary

closes #1913 , #2180, #2059, #2166, #893, #2026

Details

  1. If you are in a project initialized you have the options to add a new remote or create a new repository inside.
  2. origin repo is suggested every if doesn't exist. If the project is created previously, don't suggest a url, else, then suggest the url located in github.com.
  3. You have options to create a dir for the project.
  4. Fixed the confused Github repo creation.

@abdullahceylan
Copy link

I've applied these changes manually and tried locally for #2059 but this PR doesn't fix that issue.

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ephelsa Thank you for your contribution!

It was hard for us to thoroughly review your changeset because of its size, and also because our team is not 100% sure how we want the end behavior to be, exactly. So please bear with us while we make the decision. 🙇

@vilmibm vilmibm changed the title gh repo create improves gh repo create improvements Dec 16, 2020
@vilmibm vilmibm mentioned this pull request Jan 20, 2021
@vilmibm
Copy link
Contributor

vilmibm commented Jan 21, 2021

Thanks for this effort! It is admirable. We're going to close this as it's a lot at once and, as it is, we feel that repo create needs a fundamental overhaul. That overhaul would be even harder if we got this cleaned up and merged. In the future it's easier for us to get smaller PRs that address a single issue at a time.

@vilmibm vilmibm closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing prompt for creating repos

4 participants