Add PR Title to CommitHeadline during merge PR#1627
Merged
Conversation
mislav
approved these changes
Sep 7, 2020
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thank you! No worries; I've added the tests.
I've also scoped this change to only the squash mode, to avoid changing behavior for either --merge or --rebase modes.
samcoe
approved these changes
Sep 8, 2020
mislav
added a commit
that referenced
this pull request
Feb 16, 2021
For single-commit PRs, the commit subject will be the subject of the head commit and the PR number. For multi-commit PRs, the commit subject will be the PR title and PR number. Instead of trying to replicate this logic client-side, omit the `commitHeadline` param and let the server apply defaults appropriately. Reverts #1627
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple implementation of #1621
I'd like to also provide some testing for it, but I'm completely new to Go and I don't know how to properly use httpmock to simulate a PR merge.