SHA pin first-party GitHub Actions#13491
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins first-party GitHub Actions (actions/*, github/*) in the repository workflows to immutable commit SHAs (with trailing version comments) to reduce tag-mutation supply-chain risk and align with existing third-party pinning practices.
Changes:
- Replaced
actions/checkoutandactions/setup-goversion-tag references with commit-SHA pins across CI workflows. - Pinned
github/codeql-action/*steps to a specific commit SHA in CodeQL and SARIF upload workflows. - Pinned artifact upload/download actions used in the release/deployment workflow to specific commit SHAs.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/lint.yml | Pins checkout and setup-go to SHAs for lint and govulncheck jobs. |
| .github/workflows/govulncheck.yml | Pins checkout, setup-go, and CodeQL SARIF upload action to SHAs. |
| .github/workflows/go.yml | Pins checkout and setup-go to SHAs for build and integration tests. |
| .github/workflows/detect-spam.yml | Pins checkout to a SHA for the spam-detection workflow. |
| .github/workflows/deployment.yml | Pins checkout, setup-go, and artifact upload/download actions to SHAs in release/deployment jobs. |
| .github/workflows/codeql.yml | Pins checkout, setup-go, and CodeQL actions (init/analyze/upload-sarif) to SHAs. |
| .github/workflows/bump-go.yml | Pins checkout and setup-go to SHAs for the scheduled Go bump workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 0
Pins every actions/* and github/* uses: reference in .github/workflows to its commit SHA, with the human-readable version preserved in a trailing comment, matching the convention already used for third-party actions. Removes the supply-chain exposure left by the floating @vn tags now that dependabot has a 3-day cooldown configured. Closes #13490 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
babakks
approved these changes
May 22, 2026
BagToad
approved these changes
May 22, 2026
This was referenced May 22, 2026
pull Bot
pushed a commit
to Jimimaku/go-gh
that referenced
this pull request
May 22, 2026
Pins every actions/* and github/* uses: reference in .github/workflows to its commit SHA, with the human-readable version preserved in a trailing comment, matching the convention already used for third-party actions. Removes the supply-chain exposure left by floating @vn tags now that dependabot has a 3-day cooldown configured. Follows cli/cli#13491 (cli/cli) and cli/cli#13490. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pull Bot
pushed a commit
to NOUIY/gh-extension-precompile
that referenced
this pull request
May 22, 2026
Pins every actions/* and github/* uses: reference in .github/workflows to its commit SHA, with the human-readable version preserved in a trailing comment, matching the convention already used for third-party actions. Removes the supply-chain exposure left by floating @vn tags now that dependabot has a 3-day cooldown configured. Follows cli/cli#13491 (cli/cli) and cli/cli#13490. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13490.
What
Replaces every
actions/*andgithub/*uses:reference in.github/workflows/*.ymlwith the equivalent commit SHA, preserving the human-readable version in a trailing comment. This matches the convention already used for third-party action pins in this repo, e.g.golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0.Unique pins introduced:
actions/checkoutde0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2actions/setup-go4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0actions/upload-artifact043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1actions/download-artifact3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1github/codeql-action/{init,analyze,upload-sarif}7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4.36.0actions/attestwas already SHA-pinned and is unchanged.Some screenshots to verify shas above:
Why
Per #13490: with the 3-day dependabot cooldown configured for both
gomodandgithub-actions, version-tag references give no real benefit (dependabot still opens PRs on patch releases) while leaving us exposed to tag-mutation supply chain attacks on first-party namespaces. SHA pinning is the more consistent and defensible posture and matches what we already do for third-party actions.Verification
checkout/setup-go/codeql-action/upload-artifactcall is exercised by thelint,go,codeql, andgovulncheckworkflows on this PR.deployment.yml(download-artifact, additionalupload-artifact/checkoutinvocations) are not exercised by PR workflows. Since this change only swaps the ref (no argument changes), and the same actions are exercised elsewhere on PR, the residual risk at the next release is low.<sha> # vX.Y.Zpins and will bump both the SHA and the comment on the next patch release, validating the chosen format.Out of scope
desktop/gh-cli-and-desktop-shared-workflows/...@mainreusable workflow references. These are jointly owned with the desktop team and we should pin the actions used in them, but I don't think we suffer much exposure by keeping first party on@main?