Skip to content

Link to Accessibility category for community discussions instead of ACR#13481

Merged
BagToad merged 2 commits into
trunkfrom
mx/update-a11y-link
May 22, 2026
Merged

Link to Accessibility category for community discussions instead of ACR#13481
BagToad merged 2 commits into
trunkfrom
mx/update-a11y-link

Conversation

@mxie

@mxie mxie commented May 21, 2026

Copy link
Copy Markdown
Member

The Accessibility Conformance Report (ACR) is only valuable in that it
outlines how GitHub CLI measures up against the accessibility standards.
However, it's confusing to link to that when the CTA in gh a11y is to
"join the conversation" and share feedback. In this case, it's more
appropriate to route users directly to the community discussions instead.

The Accessibility Conformance Report (ACR) is only valuable in that it
outlines how GitHub CLI measures up against the accessibility standards.
However, it's confusing to link to that when the CTA in `gh a11y` is to
"join the conversation" and share feedback. In this case, it's more
appropriate to route users directly to the community discussions instead.
@mxie mxie requested a review from a team as a code owner May 21, 2026 16:02
@mxie mxie requested review from babakks and Copilot May 21, 2026 16:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the gh accessibility (hidden a11y) command’s “Join the conversation” call-to-action to direct users to the GitHub Community Accessibility Discussions category rather than the CLI Accessibility Conformance Report (ACR).

Changes:

  • Introduces distinct constants for the ACR URL and the Accessibility Discussions category URL.
  • Keeps --web opening the ACR page while updating the long help text CTA link to point at the Discussions category.
Show a summary per file
File Description
pkg/cmd/accessibility/accessibility.go Splits ACR vs community feedback URLs and updates the help text CTA link to route users to the Accessibility Discussions category.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines 37 to +42
RunE: func(cmd *cobra.Command, args []string) error {
if opts.Web {
if opts.IO.IsStdoutTTY() {
fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", text.DisplayURL(webURL))
fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", text.DisplayURL(acrURL))
}
return opts.Browser.Browse(webURL)
return opts.Browser.Browse(acrURL)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I intentionally left this in because the ACR page does provide more information about accessibility in gh, which aligns with how other commands with -w flags open up to their browser equivalent views. It would be misleading to link to the discussions URL instead.

@BagToad BagToad merged commit 87c8d19 into trunk May 22, 2026
11 checks passed
@BagToad BagToad deleted the mx/update-a11y-link branch May 22, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants