Trigger triage check-requirements on ready_for_review#13383
Merged
Conversation
When a PR is opened as draft and later marked ready for review, the check-requirements job's if filter excluded the ready_for_review action, so the screening workflow never ran and unmet-requirements was never applied. Add ready_for_review to the action filter so screening runs when a draft PR transitions to requesting review. Companion fix in desktop/gh-cli-and-desktop-shared-workflows updates the called workflow's own filters to handle ready_for_review consistently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the PR triage “check requirements” screening workflow runs when a draft external PR is marked ready for review, preventing draft-then-ready PRs from skipping automated screening.
Changes:
- Add
ready_for_reviewto thecheck-requirementsjobif:action filter in the PR triage workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/triage-pull-requests.yml |
Expands check-requirements job gating to include ready_for_review so screening triggers when drafts are marked ready. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
babakks
approved these changes
May 9, 2026
babakks
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an external PR is opened as draft and later marked ready for review, the calling
check-requirementsjob here only matchedopened/reopened/edited, so the shared screening workflow wasn't invoked on theready_for_reviewevent. PRs that open as draft slip past auto-screening (nounmet-requirementslabel, no auto-close timer).Adds
ready_for_reviewto the job'sif:filter.Pairs with desktop/gh-cli-and-desktop-shared-workflows#18, which fixes the called workflow's own internal filters. Both must land for screening to resume on draft-then-ready PRs.