Fix skills acceptance tests#13365
Merged
Merged
Conversation
Member
Author
|
CC @SamMorrowDrums and @tommaso-moro for manual review until we get you added back as reviewers. |
9f79bd3 to
f47e459
Compare
SamMorrowDrums
left a comment
Contributor
There was a problem hiding this comment.
I cannot approve, but this is tantamount to an approval
babakks
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two acceptance tests in
TestSkillswere failing due to code changes that weren't reflected in the test expectations:skills-publish-dry-run: The nested skills discovery change (9a368f45e) madeDiscoverLocalSkillswalk deeper, sogh skill publish --dry-run $WORKwas findingtest-repo/skills/hello-world/SKILL.mdinside $WORK instead of failing. Fixed by using an explicit empty directory for the "no skills" test case. Also removed a test case combining--fixand--dry-runwhich are now mutually exclusive flags.skills-install-namespaced: PR #13266 intentionally flattened skill installs to useskill.Nameinstead ofInstallName()because agent clients only discover immediate subdirectories. The test still expected namespaced directory layout (alice/deploy/). Updated to use distinct base names (alice-deploy,bob-deploy) and expect flat install paths.Before
After