Running commands outside of a git repo changed in latest release and has unhelpful output #7556
Description
Describe the bug
Running any command that expects to work with a git repo, outside of a repo dir exits silently with exit code 128
➜ workspace gh version
gh version 2.30.0 (2023-05-30)
https://github.com/cli/cli/releases/tag/v2.30.0Steps to reproduce the behavior
v2.30.0
➜ workspace GH_DEBUG=1 gh release create v1.2.3
[git remote -v]
➜ workspace echo $?
128v2.29.0
➜ workspace ./cli/bin/gh release create v1.2.3
failed to run git: fatal: not a git repository (or any of the parent directories): .git
➜ workspace echo $?
1Investigation
git bisect points to Allow creating of nested aliases @samcoe
I haven't done any further investigation into the contents of that commit to determine where the change lies.