-
Notifications
You must be signed in to change notification settings - Fork 8k
Open
Labels
bugSomething isn't workingSomething isn't workinggh-prrelating to the gh pr commandrelating to the gh pr commandpriority-3Affects a small number of users or is largely cosmeticAffects a small number of users or is largely cosmetic
Description
Describe the bug
❯ gh --version
gh version 1.5.0 (2021-01-21)
https://github.com/cli/cli/releases/tag/v1.5.0
When merging a PR from a branch on a different fork (than the base branch) with squash and delete enabled via the gh cli causes the PR to be merged with a squashed commit, but the source branch is not deleted either locally or remotely.
Steps to reproduce the behavior
- Create a PR from a branch on a fork different from the base branch.
- Merge the PR via the cli with squash and delete-branch enabled:
gh merge pr -s -d xx - The PR should get merged and the source branch deleted locally and remotely.
Expected vs actual behavior
Expected result:
The PR should get merged and the source branch deleted locally and remotely.
Actual result:
The PR gets merged but the source branch are not deleted locally or remotely.
Logs
❯ gh pr merge -s -d 50
✔ Squashed and merged pull request #50 (Various updates)
❯ gbd feature/updates
warning: deleting branch 'feature/updates' that has been merged to
'refs/remotes/origin/feature/updates', but not yet merged to HEAD.
Deleted branch feature/updates (was 0d02dc6).
❯ gp origin :feature/updates To github.comcast.com:VRanga000/pulumi.git
- [deleted] feature/updates
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggh-prrelating to the gh pr commandrelating to the gh pr commandpriority-3Affects a small number of users or is largely cosmeticAffects a small number of users or is largely cosmetic