Skip to content

Fixes #1232 - add support for the "@container" keyword#1241

Merged
jakubpawlowicz merged 1 commit into
clean-css:masterfrom
sevikerr:1232-container-keyword
Jan 6, 2023
Merged

Fixes #1232 - add support for the "@container" keyword#1241
jakubpawlowicz merged 1 commit into
clean-css:masterfrom
sevikerr:1232-container-keyword

Conversation

@sevikerr

@sevikerr sevikerr commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

Hi.
I found a solution how to fix the support of the "@container" keyword.
See opened issue here #1232.

@jakubpawlowicz

Copy link
Copy Markdown
Collaborator

Thanks @sevikerr, I'm merging.

@jakubpawlowicz jakubpawlowicz merged commit 87a741c into clean-css:master Jan 6, 2023
@sevikerr

sevikerr commented Jan 6, 2023

Copy link
Copy Markdown
Contributor Author

Thanks a lot! 🔥

@sevikerr sevikerr deleted the 1232-container-keyword branch January 10, 2023 12:59
@woody-li

Copy link
Copy Markdown

Thank you for your contribution, it resolves my problem.
Is there a new release contains the changing? @jakubpawlowicz

@jakubpawlowicz

Copy link
Copy Markdown
Collaborator

I'll do my best to push one this week.

@jakubpawlowicz

Copy link
Copy Markdown
Collaborator

@woody-li The fix is out in 5.3.2.

@woody-li

Copy link
Copy Markdown

Got it, thanks.

@AndrewKubow

AndrewKubow commented Mar 14, 2024

Copy link
Copy Markdown

For those who searching solution for Gulp project with gulp-clean-css plugin, you need to override clean-css version in packedge.json
{
"name": "...",
...
"scripts": {
....
},
"devDependencies": {
"gulp": "^4.0.2",
"gulp-clean-css": "^4.3.0",
...
"clean-css": "^5.3.3"
},
"overrides": {
....
"clean-css": "$clean-css"
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants