[QuarkusClassLoaderHandler] Check for both elements and split element fields to accomdate Quarkus 3.15.x and earlier and 3.16.x and later.
#893
Conversation
…nt fields to accomdate Quarkus 3.15.x and earlier and 3.16.x and later. Fixes classgraph#391.
| if(elements == null) { | ||
| elements = new ArrayList<>(); | ||
| for(String fieldName : new String[] {"normalPriorityElements", "lesserPriorityElements"}) { | ||
| elements.addAll((Collection<Object>) classpathOrder.reflectionUtils.getFieldVal(false, |
There was a problem hiding this comment.
Please check if getFieldVal returns null before calling addAll here.
There was a problem hiding this comment.
Yeah, good idea :)
|
Other than the one change I requested, looks good -- thank you, @michael-simons! |
|
Thanks, @lukehutch, change is done. |
|
Excellent, thank you @michael-simons! Merging. You said in the issue that you would write the full URL handler to handle in-memory classes. I assume that will build on this PR. I will wait until that is available to push out a release. Thanks for volunteering to do that work too. |
|
To help OGM users I’d love to see this go out first (also less pressure on me to get this right) if that’s ok with you. |
This is a follow up on issue classgraph#891 and the preceding PR classgraph#893 and brings two changes: * The `QuarkusClassLoaderHandler` is a bit more explicit now about how the elements returned from the class loader are treated * The `FastPathResolver` can be simplified using only one pattern
This is a follow up on issue classgraph#891 and the preceding PR classgraph#893 and brings two changes: * The `QuarkusClassLoaderHandler` is a bit more explicit now about how the elements returned from the class loader are treated * The `FastPathResolver` can be simplified using only one pattern
|
@michael-simons Released in 4.8.178 (and I'm releasing another unrelated PR that I forgot about in 4.8.179). PS Narcissus still has build issues (I opened a new issue there), but I decided to just push out ClassGraph without those fixes, because you need it quickly! |
Fixes #891 (Sorry, typo and tagged the wrong issue)