@chrisr3 This is the correct fix -- thank you for this pull request, and for the unit test! Released in version 4.8.134.

@chrisr3 This is the correct fix -- thank you for this pull request, and for the unit test! Released in version 4.8.134.

Thanks @lukehutch, although I wasn't quite expecting it to be merged just yet. I think there is still an issue with ClasspathElementModule.java because closing the InputStream returned by its Resource.open() method will not yet reset its isOpen field.

@chrisr3 Good catch, please see the latest commit above, and let me know if this resolves your concern.

I'll check the rest of the Resource implementations to make sure they're not missing any more resource close actions.

Hi @lukehutch,

Not really, because the super.close() in Resource.close() should handle closing the InputStream already. My point was more that InputStream.close() doesn't close the Resource as it would for the other Resource types.

Chris

@chrisr3 Yes, I just realized this and removed the last commit :-)

I understand the concern now. I have an InputStream wrapper in ClassGraph that allows a custom close action to be added. I'll wrap it in that.

@chrisr3 OK, closing the InputStream should close the underlying Resource now.

However I noticed another problem: the ByteBuffer returned by ModuleReaderProxy#read(String path) does not close the underlying Resource either when ModuleReaderProxy#release(ByteBuffer) is called.

Last time I tried implementing a custom ByteBuffer (which is a ton of work!), I got all the way to the end of the process and then discovered that a critical method is non-public (I forget which one) -- so it is not possible to extend ByteBuffer in user code, it is only possible for the JDK team to add new ByteBuffer instances. I may need to change the ClassGraph API to return a ByteBufferWrapper instance that holds a ByteBuffer and also a reference to the underlying Resource, so that that can be closed.

I extended the Resource interface to include a readCloseable() method that returns a CloseableByteBuffer that calls Resource#close() when CloseableByteBuffer#close() is called. I think this is the best that can be done, since ByteBuffer cannot be extended (the problem is that ByteBuffer has no protected constructors).

Released these fixes in version 4.8.135. Thanks!