Skip to content

Don't read through and store classpath elements if they won't be used…#422

Merged
lukehutch merged 1 commit into
classgraph:masterfrom
nsoft:master
Apr 30, 2020
Merged

Don't read through and store classpath elements if they won't be used…#422
lukehutch merged 1 commit into
classgraph:masterfrom
nsoft:master

Conversation

@nsoft

@nsoft nsoft commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

…. Fixes #421

@lukehutch

Copy link
Copy Markdown
Member

Thanks for the PR. I might tweak the logic a bit (e.g. explicitly disable java.class.path if parent classloaders are disabled), but otherwise it looks good to me.

@lukehutch lukehutch merged commit c33eea4 into classgraph:master Apr 30, 2020
lukehutch added a commit that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClasspathFinder is reading bytes into memory and immediately throwing them away

2 participants