408: Added optional resolution to jdk and sun packages#409
Conversation
|
@skahmann Thanks for this contribution. Will I need to replace all uses of classes in these packages with reflective access and a sane fallback, for OSGi environments that do not contain these packages? |
|
@skahmann Actually I checked, and all the access to these classes is already via reflection, with a sane fallback (requiring garbage collection to unmap byte buffers, rather than explicitly unmapping them). However, the module descriptor still uses: Replacing these with Is it safe to assume that OSGi projects will never use JPMS modules, and continue using the legacy classpath? |
|
I did some testing using Apache Karaf and everything seems to be working okay. I think it's safe to assume the OSGi runtime makes these classes available. I was tuned into this fix based on this issue: assertj/assertj#1663 |
|
@skahmann Thanks. Ș do this question:
|
Closes 408