-
Notifications
You must be signed in to change notification settings - Fork 63
fix install location of CMake configuration files #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix install location of CMake configuration files #116
Conversation
lib/clSPARSE/cmake -> lib/cmake/clSPARSE
|
I may not understand this completely, but this PR seems to be not needed? I am looking at the find_package() documentation, and the path searching logic reads: My original path should correspond to the 4th row on windows and the 7th row on unix? Where does the cmake string precede the lib name? Is it not working for you? |
|
The unofficial consensus on Linux is to use option 5. Never came across a project using option 7 TBH. Besides, this would make things consistent with other clMath projects and ArrayFire, which is always welcome from a package maintenance point-of-view. Your call. |
|
Strange how the eyes skip strings, they didn't register option 5. It's marked U, have you tested that path on windows? |
No For Windows, I would rather rely on the user providing a set of paths via the Let me insist on this issue from a packaging point-of-view. I am the current maintainer of |
|
If you could, please link to other projects that use the configure_package_config_file() macro. It would be good to see/study how others do it. |
|
Please correct me if I am wrong but all Then, an example from another which I am currently patching |
fix install location of CMake configuration files Tested on windows by building our cmake clsparse samples; works Looked at other projects hosted on GitHub; most use the suggested path 👍
* Added Travis CI build automation
* OPENCL_ROOT can be passed through env var to help find OpenCL
* ExternalBoost can select compiler through ENV{CC}
* Linux/OSX builds will find boost either in static or dynamic forms
* Cmake config package now installs to ${LIB_INSTALL_DIR}/cmake/clSPARSE - #116
* Library links to ${CMAKE_DL_LIBS} - #117
Merge branch 'develop'
Conflicts:
CMakeLists.txt
src/CMakeLists.txt
lib/clSPARSE/cmake -> lib/cmake/clSPARSE