Skip to content

Added option to disable two way data binding#346

Merged
pomek merged 2 commits into
masterfrom
i/141
Feb 6, 2023
Merged

Added option to disable two way data binding#346
pomek merged 2 commits into
masterfrom
i/141

Conversation

@przemyslaw-zan

@przemyslaw-zan przemyslaw-zan commented Feb 3, 2023

Copy link
Copy Markdown
Member

Suggested merge commit message (convention)

Feature: Added an optional option called disableTwoWayDataBinding that allows disabling the two-way data binding. It increases performance when working with large documents. Closes #141.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 577

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 570: 0.0%
Covered Lines: 158
Relevant Lines: 158

💛 - Coveralls

@pomek pomek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 594c044 into master Feb 6, 2023
@pomek pomek deleted the i/141 branch February 6, 2023 13:54
pomek added a commit to ckeditor/ckeditor5 that referenced this pull request Feb 9, 2023
Docs: Documented disableTwoWayDataBinding option. See ckeditor/ckeditor5-angular#346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The component works slow on large documents

3 participants