refactor(diskimage): rename ImageSize to ImageSizeBytes and update output formatting #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors disk image commands by renaming the field "ImageSize" to "ImageSizeBytes" and updating the output formatting for displaying disk image details.
- Refactored disk image find command to build output data with AppendDataWithLabel calls.
- Updated disk image create command to use the new field name "ImageSizeBytes".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/diskimage/disk_image_find.go | Updated output builder with AppendDataWithLabel and switched output method |
| cmd/diskimage/disk_image_create.go | Renamed field from ImageSize to ImageSizeBytes |
Comments suppressed due to low confidence (1)
cmd/diskimage/disk_image_find.go:56
- Ensure that tests have been updated to verify the new output format using WriteKeyValues, confirming that all key/value pairs are displayed as expected.
ow.WriteKeyValues()
TheRealSibasishBehera
previously approved these changes
Apr 23, 2025
TheRealSibasishBehera
approved these changes
Apr 28, 2025
uzaxirr
added a commit
that referenced
this pull request
Apr 30, 2025
…tput formatting (#535) * refactor(diskimage): rename ImageSize to ImageSizeBytes and update output formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: civo/civogo#250