Merged
Conversation
The test vectors are generated based on RFC 6188 section 7.4 . It demonstrates that the kdf for AES 192 is currently broken. It mistakenly uses the kdf in AES 256 mode as described in cisco#763.
8e3f563 to
f0064c8
Compare
Set the kdf key length to be the determined input key length. This will set it correctly for AES ICM 128/192/256. In the case of AES GCM 128 & 256 it needs to be increased by 2 to match the corresponding AES ICM cipher. fixes cisco#763
f0064c8 to
6ad7749
Compare
This was referenced Aug 28, 2025
|
|
||
| srtp_err_status_t srtp_validate_aes_256(void); | ||
|
|
||
| #ifdef GCM |
There was a problem hiding this comment.
I don't think this ifdef is needed here, you may want to run this test even when GCM is not enabled
Member
Author
There was a problem hiding this comment.
The GCM is miss used in this context, it indicates that the crypto engine is external as there is no internal implementation of AES 192 :( ... this should also be changed at some point.
Merged
seyednasermoravej
pushed a commit
to seyednasermoravej/libsrtp
that referenced
this pull request
Nov 9, 2025
Fix AES 192 kdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kdf for AES 192 is currently broken, it mistakenly uses the kdf in AES 256 mode as described in #763.
First will commit a failing test and then the fix.