Fix typo introduced by PR 559#562
Merged
pabuhler merged 1 commit intocisco:masterfrom Sep 13, 2021
lminiero:typo-fix
Merged
Conversation
paulej
approved these changes
Sep 13, 2021
Member
|
strange there was no test to catch this :( |
Contributor
Author
@pabuhler not sure, but my guess is this would have probably been tricky to catch using unit tests. We only noticed the issue when we were notified by someone using 2.4.1 about problems with |
seyednasermoravej
pushed a commit
to seyednasermoravej/libsrtp
that referenced
this pull request
Nov 9, 2025
Fix typo introduced by PR 559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo introduced by #559, where for
SRTP_AES_GCM_256the returned length isSRTP_AES_ICM_256_KEY_LEN_WSALTinstead ofSRTP_AES_GCM_256_KEY_LEN_WSALT, which causes problems when SRTP sessions are created using AES-GCM-256.