Optimize HTTP client used for GitHub#689
Merged
Conversation
Use a single instance with tweaked defaults across all the invocations. Plus use newer API of `go-github` (including google/go-github#3011 fix). Previously a default client was used which doesn't have nor request timeout nor idle connection timeout. This resulted in poor `p99` performance since sometimes connections were hanging blocking others to access `github.com`.
edigaryev
approved these changes
Feb 16, 2024
edigaryev
added a commit
that referenced
this pull request
Sep 30, 2025
edigaryev
added a commit
that referenced
this pull request
Sep 30, 2025
edigaryev
added a commit
that referenced
this pull request
Oct 6, 2025
* Larker: enable HTTP caching for GitHub API client * Bring back #689 tuning * Initialize HTTPClient once * Only use init() for tuning the HTTPClient after it's initialized * Per-instance HTTPClient and GitHub client * Share caching *http.Client for multiple github.New() invocations * Per-tenant shared HTTP cache * Use Get() methods to prevent NPE * Introduce TestGitHubHTTPCache * TestGitHubHTTPCache: test with two separate tenants * $ go mod tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single instance with tweaked defaults across all the invocations. Plus use newer API of
go-github(including google/go-github#3011 fix).Previously a default client was used which doesn't have nor request timeout nor idle connection timeout. This resulted in poor
p99performance since sometimes connections were hanging blocking others to accessgithub.com.