Merged
Conversation
Contributor
Author
|
Depends on upstream PR. The question I have there applies here to — what should we call |
a581759 to
e5ca6c3
Compare
Contributor
Author
|
@ocharles suggested just calling it |
2ab2787 to
4f07ca5
Compare
b0039f6 to
1ae4217
Compare
1ae4217 to
5a5bb49
Compare
ea49c52 to
1b2908a
Compare
1b2908a to
b789ccb
Compare
shane-circuithub
added a commit
that referenced
this pull request
Nov 2, 2022
In #182 we introduced window functions, and also refactored `indexed` to use the new window function support via `rowNumber`. However, previously `indexed` was zero-based, whereas PostgreSQL's `row_number()` function counts from one, so this change silently changed the behaviour of `indexed`. This commit restores the previous behaviour.
shane-circuithub
added a commit
that referenced
this pull request
Nov 2, 2022
In #182 we introduced window functions, and also refactored `indexed` to use the new window function support via `rowNumber`. However, previously `indexed` was zero-based, whereas PostgreSQL's `row_number()` function counts from one, so this change silently changed the behaviour of `indexed`. This commit restores the previous behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.