Merged
Conversation
Merged
f430afd to
6b9da26
Compare
Hide attaching kprobes progress from `main.go`. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Hide the attaching details of tracking skb from `main.go`. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Hide attaching kprobe to non-skb funcs from `main.go`. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
6b9da26 to
41ef81e
Compare
Member
|
Hey @Asphaltt , is it ready for the review? |
Contributor
Author
|
Yes, it is ready. |
brb
approved these changes
Jun 17, 2024
Member
brb
left a comment
There was a problem hiding this comment.
Thanks! Two nits (can be addressed in follow-up PRs).
Asphaltt
added a commit
to Asphaltt/pwru
that referenced
this pull request
Jun 17, 2024
Address comments in PR cilium#340. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Asphaltt
added a commit
to Asphaltt/pwru
that referenced
this pull request
Jul 7, 2024
Address comments in PR cilium#340. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
brb
pushed a commit
that referenced
this pull request
Jul 7, 2024
Address comments in PR #340. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
P3gEcTH8uJiYFVKb7lIn
added a commit
to P3gEcTH8uJiYFVKb7lIn/pwru
that referenced
this pull request
Oct 5, 2025
Address comments in PR cilium/pwru#340. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
dawn9444-holloway5
added a commit
to dawn9444-holloway5/pwru
that referenced
this pull request
Oct 10, 2025
Address comments in PR cilium/pwru#340. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
otpfmabtmksfrk6931CesarWolfe
added a commit
to otpfmabtmksfrk6931CesarWolfe/pwru
that referenced
this pull request
Oct 12, 2025
Address comments in PR cilium/pwru#340. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor code of attaching kprobe and attaching skb-tracking kprobe.
Signed-off-by: Leon Hwang hffilwlqm@gmail.com