Skip to content

conn: Skip original source address in hairpinning#1337

Merged
jrajahalme merged 1 commit intomainfrom
pr/tammach/same-pod-src-address
May 15, 2025
Merged

conn: Skip original source address in hairpinning#1337
jrajahalme merged 1 commit intomainfrom
pr/tammach/same-pod-src-address

Conversation

@sayboras
Copy link
Copy Markdown
Member

@sayboras sayboras commented May 14, 2025

Testing was done locally, in this PR, also in upstream #1337

@sayboras sayboras force-pushed the pr/tammach/same-pod-src-address branch from a869ae2 to 95436b7 Compare May 14, 2025 15:33
@sayboras sayboras force-pushed the pr/tammach/same-pod-src-address branch 7 times, most recently from ecd6670 to 137d7e9 Compare May 15, 2025 07:03
@sayboras sayboras force-pushed the pr/tammach/same-pod-src-address branch from 137d7e9 to 3fd7555 Compare May 15, 2025 07:47
This commit is to skip the source address restoration if the destination
address is having same value, the main reason is that Linux considers
such packets as martian source and will drop.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/same-pod-src-address branch 3 times, most recently from a9791c3 to b112d5f Compare May 15, 2025 09:31
sayboras added a commit to cilium/cilium that referenced this pull request May 15, 2025
Relates: cilium/proxy#1337

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras marked this pull request as ready for review May 15, 2025 10:36
@sayboras sayboras requested a review from a team as a code owner May 15, 2025 10:36
@sayboras sayboras requested a review from jrajahalme May 15, 2025 10:36
Copy link
Copy Markdown
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks!

@jrajahalme jrajahalme added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 6012992 May 15, 2025
6 checks passed
@jrajahalme jrajahalme deleted the pr/tammach/same-pod-src-address branch May 15, 2025 16:59
@sayboras sayboras mentioned this pull request May 16, 2025
1 task
sayboras added a commit to cilium/cilium that referenced this pull request May 16, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 16, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 17, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 17, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 17, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 17, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 19, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit to cilium/cilium that referenced this pull request May 19, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 19, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request May 20, 2025
This is to pick up the changes in cilium/proxy#1337, which fixes the
issue on same src and dest IPs in hair-pinning case.

Relates: cilium/proxy#1337
Relates: #39531
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants