Skip to content

Reduce size of bugtool binary#6237

Merged
aanm merged 2 commits intomasterfrom
pr/tgraf/optimize-bugtool
Nov 27, 2018
Merged

Reduce size of bugtool binary#6237
aanm merged 2 commits intomasterfrom
pr/tgraf/optimize-bugtool

Conversation

@tgraf
Copy link
Copy Markdown
Contributor

@tgraf tgraf commented Nov 14, 2018 •
edited
Loading 

Deprecate bugtool HTTP server option (--serve)

This change is Reviewable

@tgraf tgraf added kind/enhancement This would improve or streamline existing functionality. pending-review labels Nov 14, 2018
@tgraf tgraf added this to the 1.4-feature milestone Nov 14, 2018
@tgraf tgraf requested a review from a team as a code owner November 14, 2018 04:29
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Nov 14, 2018

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 14, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 43.086% when pulling ece3cb6 on pr/tgraf/optimize-bugtool into 0d3a186 on master.

@ianvernon
Copy link
Copy Markdown
Member

ianvernon commented Nov 14, 2018

Build failed due to cmdref not being updated:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8044/

@joestringer
Copy link
Copy Markdown
Member

joestringer commented Nov 19, 2018

Should probably minor release note this as something like "Deprecate bugtool HTTP server option".

@tgraf
bugtool: Remove dependency on logrus
f13b67e 
Reduces the binary size to 11M

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/optimize-bugtool branch from 0d20ada to 258ddca Compare November 26, 2018 14:47
@tgraf tgraf added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed dont-merge/needs-release-note labels Nov 26, 2018
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Nov 26, 2018

Should probably minor release note this as something like "Deprecate bugtool HTTP server option".

I've added an item to the upgrade notes.

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Nov 26, 2018

test-me-please

@tgraf
bugtool: Remove --serve option
ece3cb6 
This reduces the binary size to 6MB. Since this is technically a API change, a
release note entry was added to the ugprade section.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/optimize-bugtool branch from 258ddca to ece3cb6 Compare November 26, 2018 21:37
@tgraf tgraf requested a review from a team as a code owner November 26, 2018 21:37
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Nov 26, 2018

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Nov 26, 2018

test-me-please

1 similar comment
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Nov 27, 2018

test-me-please

@aanm aanm merged commit a78b5e1 into master Nov 27, 2018
@aanm aanm deleted the pr/tgraf/optimize-bugtool branch November 28, 2018 13:17
@sayboras sayboras mentioned this pull request Jul 15, 2020
Merged
sayboras added a commit to sayboras/cilium that referenced this pull request Jul 15, 2020
@sayboras
docs(troubleshooting): Remove --serve flag in bugtool
5418463 
The flag --serve is removed in bugtool in PR cilium#6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
qmonnet pushed a commit that referenced this pull request Jul 15, 2020
@sayboras @qmonnet
docs(troubleshooting): Remove --serve flag in bugtool
23265dd 
The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
brb pushed a commit that referenced this pull request Jul 15, 2020
@sayboras @brb
docs(troubleshooting): Remove --serve flag in bugtool
83cfba8 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb pushed a commit that referenced this pull request Jul 16, 2020
@sayboras @brb
docs(troubleshooting): Remove --serve flag in bugtool
57b0aac 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
christarazi pushed a commit that referenced this pull request Jul 20, 2020
@sayboras @christarazi
docs(troubleshooting): Remove --serve flag in bugtool
2d73d30 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
jrfastab pushed a commit that referenced this pull request Jul 22, 2020
@sayboras @jrfastab
docs(troubleshooting): Remove --serve flag in bugtool
e8d70d8 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
christarazi pushed a commit that referenced this pull request Jul 22, 2020
@sayboras @christarazi
docs(troubleshooting): Remove --serve flag in bugtool
5ba5b05 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
christarazi pushed a commit that referenced this pull request Jul 30, 2020
@sayboras @christarazi
docs(troubleshooting): Remove --serve flag in bugtool
bfc4f6d 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
gandro pushed a commit that referenced this pull request Jul 30, 2020
@sayboras @gandro
docs(troubleshooting): Remove --serve flag in bugtool
52abfe4 
[ upstream commit 23265dd ]

The flag --serve is removed in bugtool in PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanm aanm aanm approved these changes

+1 more reviewer

@ianvernon ianvernon ianvernon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Milestone

1.4-feature

Development

Successfully merging this pull request may close these issues.

5 participants

@tgraf @coveralls @ianvernon @joestringer @aanm