Conversation
daemon/server/handlers.go
Outdated
Contributor
There was a problem hiding this comment.
What does this magic value do? 🎱
Member
Author
There was a problem hiding this comment.
It's the max memory for that go can use to parse the form. Fixed!
Contributor
|
W00t, we have a loading gif. Code LGTM aside from the minor build failure. |
Contributor
|
Providing ACK given build is fixed and magic value is explained. |
4f63473 to
e5502ab
Compare
daemon/server/ui.go
Outdated
Member
Author
There was a problem hiding this comment.
@tgraf I had to add this init() so the tests wouldn't fail.
Acked-by: Thomas Graf <thomas@cilium.io> Signed-off-by: André Martins <andre@cilium.io>
This was referenced Aug 31, 2020
2 tasks
2 tasks
Closed
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
3 tasks
yoursanonymous
pushed a commit
to yoursanonymous/cilium
that referenced
this pull request
Jan 31, 2026
Fix link to example sources in k3s blog post
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Martins andre@cilium.io