Skip to content

.github/workflows: do not use deployments for environments#44908

Merged
aanm merged 1 commit intomainfrom
pr/do-not-use-deployments
Apr 1, 2026
Merged

.github/workflows: do not use deployments for environments#44908
aanm merged 1 commit intomainfrom
pr/do-not-use-deployments

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Mar 20, 2026

None of the environments that we use in our workflows make use of deployments, therefore we can disabled them everywhere.

@aanm aanm requested a review from a team as a code owner March 20, 2026 11:21
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Mar 20, 2026
@aanm aanm requested review from a team as code owners March 20, 2026 11:21
@aanm aanm added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label Mar 20, 2026
@aanm aanm requested a review from joestringer March 20, 2026 11:21
@aanm aanm added needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Mar 20, 2026
@aanm aanm requested a review from christarazi March 20, 2026 11:21
@aanm aanm enabled auto-merge March 20, 2026 11:21
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Mar 20, 2026

/test

@aanm
Copy link
Copy Markdown
Member Author

aanm commented Mar 20, 2026

The linter is failing because rhysd/actionlint#639 is not merged yet.

None of the environments that we use in our workflows make use
of deployments, therefore we can disabled them everywhere.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/do-not-use-deployments branch from 6274f26 to 254ec88 Compare April 1, 2026 08:43
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Apr 1, 2026

/test

1 similar comment
@cilium-ariane
Copy link
Copy Markdown

cilium-ariane bot commented Apr 1, 2026

/test

@aanm aanm added this pull request to the merge queue Apr 1, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 1, 2026
Merged via the queue into main with commit f3fea47 Apr 1, 2026
80 of 81 checks passed
@aanm aanm deleted the pr/do-not-use-deployments branch April 1, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants