Add support for environment > deployment: false#639
Closed
springmeyer wants to merge 2 commits intorhysd:mainfrom
Closed
Add support for environment > deployment: false#639springmeyer wants to merge 2 commits intorhysd:mainfrom
springmeyer wants to merge 2 commits intorhysd:mainfrom
Conversation
Contributor
Author
|
@rhysd just also added timezone support as well to this PR. This was also added in https://github.blog/changelog/2026-03-19-github-actions-late-march-2026-updates/#github-actions-now-allows-developers-to-use-environments-without-auto-deployment and I'm seeing false-positives when testing it (before this PR). |
Contributor
|
@springmeyer #641 also implements timezone support 😉 |
rhysd
approved these changes
Mar 30, 2026
Owner
|
I'm sorry for the delay. I couldn't take enough time to review this. |
|
@springmeyer #641 has been merged for the timeline support, but |
Owner
|
Yes, I notice it. I'm cherry-picking implementation in this branch now. Thanks anyway. |
Owner
|
I cherry-picked the implementation at 0ef3e18. |
Contributor
Author
|
thanks @rhysd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for this new github actions feature: https://github.blog/changelog/2026-03-19-github-actions-late-march-2026-updates/#github-actions-now-allows-developers-to-use-environments-without-auto-deployment
https://github.com/orgs/community/discussions/36919#discussioncomment-16214515