.github: use create eks nodegroup action for l7-perf workflow#44706
Merged
.github: use create eks nodegroup action for l7-perf workflow#44706
Conversation
Member
Author
|
/test |
Member
Author
|
/l7-perf |
1 similar comment
Member
Author
|
/l7-perf |
giorio94
approved these changes
Mar 10, 2026
Member
giorio94
left a comment
There was a problem hiding this comment.
/lgtm, thanks! Could you extend the commit message with a bit more details for future reference?
nebril
approved these changes
Mar 10, 2026
Member
nebril
left a comment
There was a problem hiding this comment.
LGTM, I agree with Marco's nits, especially dropping mode parameter.
ae81872 to
125e3c7
Compare
Make `setup-eks-nodegroup` action generic by providing an option to override the node group details. This allows users of the action to define custom node group setup as per the workflow requirement. Additionally this commit migrates `l7-perf.yaml` and `scale-test-egw.yaml` workflows to use the updated action definition by providing the custom node group configuration. Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
125e3c7 to
374c99c
Compare
Member
Author
|
/scale-egw |
Member
Author
|
/l7-perf |
Member
Author
|
/test |
Member
Author
joestringer
reviewed
Mar 17, 2026
tommyp1ckles
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42363
Since different workflows have different need of how node groups are configured add an option to provide the full node groups yaml block.