Merged
Conversation
Contributor
Author
|
@akos011221 @ti-mo There was conflicts backporting #44513, namely #43479 refactored a lot of this code. I went ahead and tried to just do the backport myself. Please take a look to ensure the changes are correct/equivalent. |
Contributor
Author
|
/test |
Contributor
|
@tommyp1ckles reviewed the changes, it looks correct to me. |
Contributor
|
Failing consistently at creating NodeGroup in ci-eks. |
[ upstream commit 61e04f7 ] [ backporters notes: overlay.go did not previously prior to 43479. This moves this logic to where the bpf overlay was previouly created at replaceOverlayDatapath ] The InterfaceMAC field is not filled from the tunnel dev's MAC address. Because of this the BPF program for the overlay resolves to 00:00:00:00:00:00, sending this broken response to the VTEP ARP lookup request. Fixes: #44453 Signed-off-by: akos011221 <orbanakos2001@gmail.com> Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
9be6a76 to
8e27286
Compare
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: