Skip to content

datapath: add missing interface MAC configuration for BPFOverlay config#44513

Merged
ti-mo merged 1 commit intocilium:mainfrom
akos011221:fix/vtep-overlay-if-mac
Mar 4, 2026
Merged

datapath: add missing interface MAC configuration for BPFOverlay config#44513
ti-mo merged 1 commit intocilium:mainfrom
akos011221:fix/vtep-overlay-if-mac

Conversation

@akos011221
Copy link
Copy Markdown
Contributor

@akos011221 akos011221 commented Feb 24, 2026

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

The InterfaceMAC field is not filled from the tunnel dev's MAC address. Because of this the BPF program for the overlay resolves to 00:00:00:00:00:00, sending this broken response to the VTEP ARP lookup request.

It seems to be that the root cause was d296e0d removing the compile time option -DTHIS_INTERFACE_MAC for bpf_overlay.c, but the MAC field was not set in the replacement Go struct.

Fixes: #44453
Fixes: d296e0d

Fixed VTEP ARP responses returning 00:00:00:00:00:00 MAC due to interface MAC missing from eBPF Overlay configuration.

@akos011221 akos011221 requested a review from a team as a code owner February 24, 2026 18:57
@akos011221 akos011221 requested a review from ldelossa February 24, 2026 18:57
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 24, 2026
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 24, 2026
@maintainer-s-little-helper
Copy link
Copy Markdown

Commit b4e9a6d does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 24, 2026
@akos011221 akos011221 force-pushed the fix/vtep-overlay-if-mac branch from b4e9a6d to b617495 Compare February 24, 2026 20:42
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 24, 2026
@joestringer joestringer requested a review from ti-mo February 24, 2026 22:09
@ti-mo ti-mo added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Feb 26, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 26, 2026
Copy link
Copy Markdown
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-mo ti-mo added needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 26, 2026
@ti-mo
Copy link
Copy Markdown
Contributor

ti-mo commented Feb 26, 2026

/test

Copy link
Copy Markdown
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-mo
Copy link
Copy Markdown
Contributor

ti-mo commented Mar 2, 2026

/test

@ti-mo ti-mo enabled auto-merge March 2, 2026 13:44
@julianwiedmann julianwiedmann added the feature/vtep Support for interacting with VXLAN Tunnel Endpoints (VTEPs) for traffic onboarding to the cluster label Mar 4, 2026
The InterfaceMAC field is not filled from the tunnel dev's MAC address.
Because of this the BPF program for the overlay resolves to
00:00:00:00:00:00, sending this broken response to the VTEP ARP lookup
request.

Fixes: cilium#44453

Signed-off-by: akos011221 <orbanakos2001@gmail.com>
@julianwiedmann julianwiedmann force-pushed the fix/vtep-overlay-if-mac branch from b617495 to 37982cf Compare March 4, 2026 10:37
@julianwiedmann
Copy link
Copy Markdown
Member

/test

1 similar comment
@julianwiedmann
Copy link
Copy Markdown
Member

/test

@ti-mo ti-mo added this pull request to the merge queue Mar 4, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 4, 2026
Merged via the queue into cilium:main with commit 61e04f7 Mar 4, 2026
78 checks passed
@tommyp1ckles tommyp1ckles mentioned this pull request Mar 9, 2026
7 tasks
@tommyp1ckles tommyp1ckles added the backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. label Mar 9, 2026
@tommyp1ckles tommyp1ckles removed the needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch label Mar 9, 2026
@tommyp1ckles tommyp1ckles mentioned this pull request Mar 9, 2026
1 task
@tommyp1ckles tommyp1ckles added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Mar 9, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. feature/vtep Support for interacting with VXLAN Tunnel Endpoints (VTEPs) for traffic onboarding to the cluster kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vxlan vtep no longer working in 1.18, arp broken?

5 participants