gatewayapi-ci: replace installing crds with make and test experimental release on PRs#44656
Merged
youngnick merged 1 commit intocilium:mainfrom Mar 16, 2026
Merged
Conversation
7ccb46e to
cd3633c
Compare
Member
Author
|
/test |
ecdd39c to
054ff6c
Compare
Member
Author
|
/test |
joestringer
reviewed
Mar 10, 2026
Member
joestringer
left a comment
There was a problem hiding this comment.
Thanks LGTM. I'd like to see confirmed evidence the new workflow code was executed/tested before merging.
e45c2f1 to
54ec0ae
Compare
youngnick
approved these changes
Mar 11, 2026
Contributor
youngnick
left a comment
There was a problem hiding this comment.
LGTM once we verify that it works by running it.
54ec0ae to
99e6c5f
Compare
Member
Author
|
/test |
aa4f860 to
ec112d3
Compare
nebril
approved these changes
Mar 11, 2026
|
/test |
ec112d3 to
b313e4a
Compare
|
/test |
b313e4a to
1fb40ca
Compare
Member
Author
|
from a resolved comment -> here is a (passing) workflow run with a temporary commit showing the workflow running https://github.com/cilium/cilium/actions/runs/22958500148/job/66643908606?pr=44656 |
948d865 to
19a1bca
Compare
Contributor
|
/test |
19a1bca to
0782c5a
Compare
This PR adds a nightly workflow for the full matrix, and on PRs only the experimental release channel is run. It also sets up the crds to be installed from the make target versus running it with cmds. Signed-off-by: xtine <xtineskim@gmail.com>
0782c5a to
b057f61
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #44645
This pr removes the commands to install the Gateway API CRDs, and instead targets the make target
make kind-servicemesh-prereqsThis pr also changes to have the full matrix run nightly, and have the experimental release channel to run on PRs. The experimental test is a superset of the standard.