Merged
Conversation
[ upstream commit b7d51e5 ] - Enable AddPath receive capability when adding BGP peers in test commands to support receiving multiple paths for the same prefix. - Sort paths by path attributes when printing to ensure deterministic output in tests. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
[ upstream commit 55f6b16 ] - Rename the variable `defaultSafiAfi` to `defaultAfiSafi` to correct the ordering of the acronym. - Copy defaultAfiSafi to avoid the in place mutation Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
[ upstream commit ab56298 ] Remove the RouteReflector field and related conversion logic from the Neighbor type as it is not currently used. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Member
Author
|
/test |
Member
|
non-blocking feedback: Do we need to be taking on the extra burden of backporting this to 1.19? It's not immediately apparent to me why this meets the backport criteria. |
joestringer
approved these changes
Mar 4, 2026
Member
joestringer
left a comment
There was a problem hiding this comment.
I'll approve just to defer to your discretion, though I feel it would save three of us a little bit of time not to backport changes like this in future.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: