Skip to content

bgp: Clean up and test improvements#44074

Merged
joestringer merged 3 commits intocilium:mainfrom
liyihuang:pr/liyih/bgp_clean_up
Jan 30, 2026
Merged

bgp: Clean up and test improvements#44074
joestringer merged 3 commits intocilium:mainfrom
liyihuang:pr/liyih/bgp_clean_up

Conversation

@liyihuang
Copy link
Copy Markdown
Contributor

@liyihuang liyihuang commented Jan 30, 2026

  • Remove unused RouteReflector
  • Enhance GoBGP test commands
  • Fix variable name typo and copy defaultAfiSafi to avoid the in place mutation
bgp: Clean up unused RouteReflector and improve GoBGP test commands

- Enable AddPath receive capability when adding BGP peers in test commands
to support receiving multiple paths for the same prefix.
- Sort paths by path attributes when printing to ensure deterministic output in tests.

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 30, 2026
@liyihuang liyihuang added area/bgp Impacts the Border Gateway Protocol feature. release-note/misc This PR makes changes that have no direct user impact. labels Jan 30, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 30, 2026
@liyihuang
Copy link
Copy Markdown
Contributor Author

/test

@liyihuang liyihuang marked this pull request as ready for review January 30, 2026 16:39
@liyihuang liyihuang requested a review from a team as a code owner January 30, 2026 16:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 30, 2026
@joestringer joestringer removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 30, 2026
@liyihuang liyihuang force-pushed the pr/liyih/bgp_clean_up branch from 98b72e5 to 4f1fc64 Compare January 30, 2026 20:16
- Rename the variable `defaultSafiAfi` to `defaultAfiSafi` to correct
the ordering of the acronym.
- Copy defaultAfiSafi to avoid the in place mutation

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Remove the RouteReflector field and related conversion logic from the
Neighbor type as it is not currently used.

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
@liyihuang liyihuang force-pushed the pr/liyih/bgp_clean_up branch from 4f1fc64 to b0a0daf Compare January 30, 2026 20:18
@liyihuang
Copy link
Copy Markdown
Contributor Author

/test

Copy link
Copy Markdown
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good. Thanks!

@liyihuang liyihuang added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 30, 2026
@joestringer joestringer added this pull request to the merge queue Jan 30, 2026
Merged via the queue into cilium:main with commit ab56298 Jan 30, 2026
76 checks passed
@liyihuang liyihuang deleted the pr/liyih/bgp_clean_up branch February 3, 2026 16:10
@YutaroHayakawa YutaroHayakawa added backport/author The backport will be carried out by the author of the PR. needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Mar 4, 2026
@YutaroHayakawa YutaroHayakawa mentioned this pull request Mar 4, 2026
1 task
@YutaroHayakawa YutaroHayakawa added the backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. label Mar 4, 2026
@YutaroHayakawa YutaroHayakawa removed the needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch label Mar 4, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bgp Impacts the Border Gateway Protocol feature. backport/author The backport will be carried out by the author of the PR. backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants