[v1.18] endpoint/bpf: remove change empty condition for updateEnvoy#44616
Merged
julianwiedmann merged 1 commit intocilium:v1.18from Mar 16, 2026
Merged
[v1.18] endpoint/bpf: remove change empty condition for updateEnvoy#44616julianwiedmann merged 1 commit intocilium:v1.18from
julianwiedmann merged 1 commit intocilium:v1.18from
Conversation
Contributor
Author
|
/test |
cb742f5 to
c5899ef
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
c5899ef to
5387c9a
Compare
Contributor
Author
|
/test |
squeed
approved these changes
Mar 6, 2026
5387c9a to
717423b
Compare
Contributor
Author
|
/test |
717423b to
13eef05
Compare
13eef05 to
6803b3f
Compare
This commit removes the !changes.Empty() condition to avoid the bug when the bpf map is no change but we still need to update the envoy network policy and add the version validation in 1.18 When there is SNI network policy with FQDN network policy, we will redirect egress all traffic to the envoy. The identity could change with wildcard FQDN policy and bpf map will keep the same. that will cause the enovy network policy not getting updated. For example,we could have the following identities in the beginning 1677721 fqdn:sts.*.amazonaws.com reserved:world 16777220 fqdn:*.amazonaws.com reserved:world When the DNS resolves the IP for sts.*.amazonaws.com, we will generate the new identity 16777223 fqdn:*.*.amazonaws.com fqdn:sts.*.amazonaws.com reserved:world If we have the SNI network policy for the pod, that will make the bpf map look like the following. root@kind-worker8:/home/cilium# cilium bpf policy get 2782 POLICY DIRECTION LABELS (source:key[=value]) PORT/PROTO PROXY PORT AUTH TYPE BYTES PACKETS PREFIX LEVEL Allow Ingress ANY ANY NONE disabled 0 0 0 0 Allow Ingress reserved:host ANY NONE disabled 0 0 0 0 Allow Egress ANY 443/TCP 13379 disabled 5904 33 24 0 With the current check logic, there is no change to the map. Then we will skip updating the envoy network policy causing envoy holding the stale identity and block the traffic. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
6803b3f to
b5153cc
Compare
Contributor
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow up for #44519. The backport causes a lot of failure. It looks like that's because 1.18 implementation is a bit different from 1.19 where we need extra condition check to get it working.
I leave the current CI failure for review so people can see it's not from this commit.