Merged
Conversation
[ upstream commit b1aa28a ] The Role/RoleBinding for cilium-tlsinterception-secrets had mismatched conditionals, causing the RoleBinding to be created without its Role when operator.enabled=false. Align both to use consistent agent-based conditionals. Fixes: #44053 Signed-off-by: Pavan More <pavansmore05@gmail.com> Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Contributor
Author
The upstream netlink library has been updated recently to include support
for {head,tail}room attributes on network devices. This change updates our
dependency to the latest unreleased commit.
The netlink library previously expressed netlinkHandle.Close() routine without
a return type. However, newer versions of the library now return an error.
This change updates the netlinkHandle.Close() call in the Devices Controller,
allowing us to log any error raised to us, because it may be a sign of a
resource leak.
Signed-off-by: Alasdair McWilliam <alasdair.mcwilliam@isovalent.com>
c4753b3 to
1bb2eb6
Compare
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cilium-tlsinterception-secretsRole/RoleBinding conditionals #44159 (@puwun)Once this PR is merged, a GitHub action will update the labels of these PRs: