helm: align cilium-tlsinterception-secrets Role/RoleBinding conditionals#44159
Merged
gandro merged 1 commit intocilium:mainfrom Feb 4, 2026
Merged
Conversation
The Role/RoleBinding for cilium-tlsinterception-secrets had mismatched conditionals, causing the RoleBinding to be created without its Role when operator.enabled=false. Align both to use consistent agent-based conditionals. Fixes: cilium#44053 Signed-off-by: Pavan More <pavansmore05@gmail.com>
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed conditional mismatch between
cilium-tlsinterception-secretsRole and RoleBinding in Helm templates.The Role incorrectly depended on
operator.enabledwhile the RoleBinding did not, causing RBAC errors whenoperator.enabled=false.Both now use consistent agent-based conditionals matching other Role/RoleBinding pairs in the same files.
Fixes: #44053