policy: return ICMPv6 "Destination unreachable" on IPv6 egress policy denials#44234
Merged
julianwiedmann merged 4 commits intocilium:mainfrom Mar 16, 2026
Merged
Conversation
Contributor
Author
0b859f6 to
e5c1918
Compare
Contributor
Author
|
I rebased this now that #44086 is merged @cilium/sig-datapath PTAL when you get a chance I would like to change the title of the PR to |
Member
|
/test |
dylandreimerink
approved these changes
Feb 16, 2026
Member
dylandreimerink
left a comment
There was a problem hiding this comment.
These changes look good to me! Nicely done
joestringer
reviewed
Feb 19, 2026
Contributor
Author
|
@joestringer PTAL when you get a chance |
Contributor
|
Looks like the metrics documentation is out of sync @Andreagit97, that's why the Smoke Test is failing. |
Rename `__tail_no_service_ipv6` into `generate_icmp6_reply`. Now `generate_icmp6_reply` can generate a generic ICMPv6 packet with type and code. Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
8789e1e to
91270de
Compare
Contributor
Author
|
Thank you @youngnick! I didn't touch any metric, so I suppose a rebase on main should be enough. @cilium/sig-datapath, I should have addressed all comments. Let me know if there is something else to do |
91270de to
64bc05e
Compare
Member
The last two patches in this series are just fix-ups for previous changes in this PR, right? Could you please squash those fix-ups into the corresponding patches? |
This changes the datapath code to add support for returning an ICMPv6 "Destination Unreachable" / "Administratively Prohibited" response for policy denials, instead of silently dropping traffic. Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
64bc05e to
8a49d56
Compare
Contributor
Author
|
Sure! Done :) |
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements ICMPv6 responses for IPv6 egress traffic (part of #41859)
The approach is very similar to the one used here #41406; the only real difference is that ICMPv6 requires rate-limiting.