bpf: move ICMPv6 packet generation functions to a separate file#44086
Merged
julianwiedmann merged 4 commits intocilium:mainfrom Feb 10, 2026
Merged
bpf: move ICMPv6 packet generation functions to a separate file#44086julianwiedmann merged 4 commits intocilium:mainfrom
julianwiedmann merged 4 commits intocilium:mainfrom
Conversation
7 tasks
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
This helper is shared by ICMPv6 and ICMPv4 and will be imported by both in future refactors. Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
The goal is to make these functions reusable for the ICMPv6 policy denial feature, so moving them to a shared icmp6.h file Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
bba06fc to
038d101
Compare
Member
|
@cilium/sig-lb @cilium/sig-datapath PTAL when you get a chance |
Member
|
/test |
tommyp1ckles
reviewed
Feb 4, 2026
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
038d101 to
8a463de
Compare
tommyp1ckles
approved these changes
Feb 10, 2026
Contributor
|
/test |
julianwiedmann
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all! I would like to tackle a point of this issue #41859.
More in detail:
I'm not familiar with the codebase, but this issue seems like a good opportunity to gain some confidence with it!
This PR is just preliminary work, very similar to what was done here 87bc3c1