[v1.18] bpf: Fix marker to skip nodeport when punting to proxy#43886
Merged
[v1.18] bpf: Fix marker to skip nodeport when punting to proxy#43886
Conversation
[ upstream commit 640e955 ] [ manual backport due to upstream nodeport code refacors ] Julian spotted that setting ctx_skip_nodeport_set(ctx) is not having the desired effect for the case when there is XDP used on the node. The ctx_skip_nodeport_set() marker is not transferred to the skb and as a result the service lookup would happen twice instead of just in the XDP layer resulting in higher per-packet cost. The latter lookup in the tcx layer for such packets is unnecessary. Therefore, use the correct ctx_set_xfer(ctx, XFER_PKT_NO_SVC). Reported-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
[ upstream commit 7f95906 ] [ manually fixing up unit test for 1.18 infra ] Add a test where the backend is local with the service L7 proxy delegate. We expect the service to be passed up the stack unmodified. XFER_PKT_NO_SVC is set to skip tcx service handling a second time. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
[ upstream commit 4fe778b ] [ manually fixing up unit test for 1.18 infra ] Add a test where the backend is remote with the service L7 proxy delegate. We expect the service to be NATed and sent out the node. XFER_PKT_NO_SVC is /not/ set in this case given the backend is not part of the local endpoint map. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
facbbe3 to
327f657
Compare
Member
Author
|
/test |
giorio94
approved these changes
Jan 20, 2026
Member
giorio94
left a comment
There was a problem hiding this comment.
Thanks, looks good to me from a backport point of view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of:
Once this PR is merged, a GitHub action will update the labels of these PRs: