check-encryption-leak: do not trace TCP RST packets as leaked#43228
Merged
jrajahalme merged 1 commit intomainfrom Dec 16, 2025
Merged
check-encryption-leak: do not trace TCP RST packets as leaked#43228jrajahalme merged 1 commit intomainfrom
jrajahalme merged 1 commit intomainfrom
Conversation
Contributor
Author
|
/test |
rgo3
approved these changes
Dec 11, 2025
nbusseneau
approved these changes
Dec 12, 2025
Member
|
/ci-l7 |
Member
|
/ci-l3-l4 |
Member
|
/ci-l7 |
Member
|
@smagnani96 You may need to rebase this to enable running the new Ci workflows ( |
This substantially reverts #41765, re-applying #36962 (modified code for readability). During our CLI tests, we observe some auto-generated TCP RST packets from the kernel in response to TCP-FIN packets sent by, most likely, some idle's timeout expiring. Envoy would generate TCP-FIN, but the kernel replies with a RST, given there's not a socket anymore listening to that port. We thought that after VinE we were able to catch such packets in our to-netdev program, but we kept observing them while adding unrelated tests to our CLI suite (see https://github.com/cilium/cilium/actions/runs/19833684454). Thus, we revert the latest change, and keep ignoring TCP RST packets. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
42ae971 to
62f993d
Compare
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This substantially reverts #41765, re-applying #36962 (modified code for readability).
During our CLI tests, we observe some auto-generated TCP RST packets from the kernel in response to TCP-FIN packets sent by, most likely, some idle's timeout expiring. Envoy would generate TCP-FIN, but the kernel replies with a RST, given there's not a socket anymore listening to that port.
We thought that after VinE we were able to catch such packets in our to-netdev program, but we kept observing them while adding unrelated tests to our CLI suite (see https://github.com/cilium/cilium/actions/runs/19833684454). Thus, we revert the latest change, and keep ignoring TCP RST packets.