check-encryption-leak: don't skip plain-text TCP RST packets#41765
Merged
julianwiedmann merged 2 commits intomainfrom Sep 25, 2025
Merged
check-encryption-leak: don't skip plain-text TCP RST packets#41765julianwiedmann merged 2 commits intomainfrom
julianwiedmann merged 2 commits intomainfrom
Conversation
7 tasks
Member
Author
|
/test |
Member
Author
|
I'll give this a few rounds through CI once the e2e-upgrade workflow is healthy again, to ensure we don't re-introduce any flakes ... |
Artyop
approved these changes
Sep 19, 2025
f34c28f to
61bc53b
Compare
Member
Author
|
/test |
smagnani96
requested changes
Sep 19, 2025
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
This LGTM, just needs small changes in the code 👍🏼
Starting from v1.18 the IPsec encryption policy is applied when egressing the native device. Therefore we should be able to catch stray TCP RSTs by the L7 proxy which didn't pass through cilium_host, and encrypt them as needed. This effectively reverts commit 09551d2 ("ci: skip plain-text TCP RST packets in bpftrace"). Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
s/masquerated/masqueraded Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
61bc53b to
440f8b3
Compare
Member
Author
|
/test |
smagnani96
approved these changes
Sep 24, 2025
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
Thanks for the changes! LGTM.
Member
Author
|
Gave CI a bunch of spins, no flakes to be seen. |
smagnani96
added a commit
that referenced
this pull request
Dec 9, 2025
This substantially reverts #41765, re-applying #36962 (modified code for readability). During our CLI tests, we observe some auto-generated TCP RST packets from the kernel in response to TCP-FIN packets sent by, most likely, some idle's timeout expiring. Envoy would generate TCP-FIN, but the kernel replies with a RST, given there's not a socket anymore listening to that port. We thought that after VinE we were able to catch such packets in our to-netdev program, but we kept observing them while adding unrelated tests to our CLI suite (see https://github.com/cilium/cilium/actions/runs/19833684454). Thus, we revert the latest change, and keep ignoring TCP RST packets. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
aanm
pushed a commit
that referenced
this pull request
Dec 15, 2025
This substantially reverts #41765, re-applying #36962 (modified code for readability). During our CLI tests, we observe some auto-generated TCP RST packets from the kernel in response to TCP-FIN packets sent by, most likely, some idle's timeout expiring. Envoy would generate TCP-FIN, but the kernel replies with a RST, given there's not a socket anymore listening to that port. We thought that after VinE we were able to catch such packets in our to-netdev program, but we kept observing them while adding unrelated tests to our CLI suite (see https://github.com/cilium/cilium/actions/runs/19833684454). Thus, we revert the latest change, and keep ignoring TCP RST packets. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
This substantially reverts #41765, re-applying #36962 (modified code for readability). During our CLI tests, we observe some auto-generated TCP RST packets from the kernel in response to TCP-FIN packets sent by, most likely, some idle's timeout expiring. Envoy would generate TCP-FIN, but the kernel replies with a RST, given there's not a socket anymore listening to that port. We thought that after VinE we were able to catch such packets in our to-netdev program, but we kept observing them while adding unrelated tests to our CLI suite (see https://github.com/cilium/cilium/actions/runs/19833684454). Thus, we revert the latest change, and keep ignoring TCP RST packets. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from v1.18 the IPsec encryption policy is applied when egressing the native device. Therefore we should be able to catch stray TCP RSTs by the L7 proxy which didn't pass through cilium_host, and encrypt them as needed.
This effectively reverts
commit 09551d2 ("ci: skip plain-text TCP RST packets in bpftrace").