Conversation
|
Commits baea0e8, 13b49c9 do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
Commit db58f9b does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
/test |
|
/test |
|
Can you do a |
This PR introduced a retry jitter that seems to cause a disconnect for global identities and the kvstore and yielding tests failures when identities are in the cache but not present in the kvstore. We've opted to revert this change and bypass blocking the allocator prior to resolving the identities Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
|
/test |
squeed
left a comment
There was a problem hiding this comment.
Looks good. In the future, can you put the ID of the reverted commit in the message? That makes it easier to trace the history. Since this commit never shipped, it's not meaningful.
odinuge
left a comment
There was a problem hiding this comment.
Thanks! This is causing a lot of test flakes, so great to get it stabilized.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #42922
Reverts: #42282