Skip to content

allocator: crd: jitter identity creation#42282

Merged
squeed merged 1 commit intocilium:mainfrom
squeed:allocator-initial-jitter
Nov 10, 2025
Merged

allocator: crd: jitter identity creation#42282
squeed merged 1 commit intocilium:mainfrom
squeed:allocator-initial-jitter

Conversation

@squeed
Copy link
Copy Markdown
Contributor

@squeed squeed commented Oct 20, 2025

This adds some jitter to the allocator backoff, as well as waiting a random time before first allocation. This aims to reduce collisions where a duplicate identity is created for the same set of labels.

This is only enabled for the CRD allocator, as it can collide when allocating the same identity. The kvstore allocator does not suffer this problem.

This works in concert with #38031, which can delay re-allocations for up to 30 seconds. That option protects against overload when a large namespace is re-labeled. This is smaller in scope, with less delay, intended only to reduce duplicates.

@squeed squeed requested review from a team as code owners October 20, 2025 11:56
@squeed squeed added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 20, 2025
@squeed squeed requested review from fristonio and giorio94 October 20, 2025 11:56
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Oct 20, 2025
Copy link
Copy Markdown
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

This adds some jitter to the allocator backoff, as well as waiting a
random time before first allocation. This aims to reduce collisions
where a duplicate identity is created for the same set of labels.

This is only enabled for the CRD allocator, as it can collide when
allocating the same identity. The kvstore allocator does not suffer this
problem.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed force-pushed the allocator-initial-jitter branch from 1e0178f to 93cde57 Compare November 10, 2025 13:35
Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@squeed
Copy link
Copy Markdown
Contributor Author

squeed commented Nov 10, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 10, 2025
@squeed squeed added this pull request to the merge queue Nov 10, 2025
Merged via the queue into cilium:main with commit ebcfe25 Nov 10, 2025
72 of 73 checks passed
@squeed squeed deleted the allocator-initial-jitter branch November 10, 2025 19:16
@squeed squeed added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Dec 8, 2025
@squeed
Copy link
Copy Markdown
Contributor Author

squeed commented Dec 8, 2025

This was reverted in #43127

@squeed squeed mentioned this pull request Dec 8, 2025
8 tasks
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

4 participants