Skip to content

renovate: Update image-tools images regex#43087

Merged
julianwiedmann merged 1 commit intomainfrom
pr/HadrienPatte/image-tools-renovate
Dec 2, 2025
Merged

renovate: Update image-tools images regex#43087
julianwiedmann merged 1 commit intomainfrom
pr/HadrienPatte/image-tools-renovate

Conversation

@HadrienPatte
Copy link
Copy Markdown
Member

This PR updates the custom versioning regex used for the images from the image-tools repository to reflect image versioning scheme changes from cilium/image-tools#413.

The existing regex is kept for images that still follow the previous versioning scheme (image-compilers, image-maker, startup-script and image-tester). Other images now have a slighlty more elaborate regex to account for their "semantic + timestamp + commit sha" new versioning scheme.

Reference: https://docs.renovatebot.com/modules/versioning/regex/

Note: we're using the build capture group for the timestamp element

Note: Renovate requires that all previous capture groups match (even if with an empty value), this is why the patch capture group is configured to either match the patch version component or match to an empty value in case the version does not have a patch number (like for the checkpatch and network-perf images).

The new regex properly matches all the expected segments for the concerned images:
image

Using this renovate config on a test repository, renovate properly tracks the versioning of those images:
image
Note: in that example above, the llvm image has a tag from the old versioning scheme but that image now uses the new versioning scheme so renovate ignores it.

This PR updates the custom versioning regex used for the images from the
`image-tools` repository to reflect image versioning scheme changes from
cilium/image-tools#413.

The existing regex is kept for images that still follow the previous
versioning scheme (`image-compilers`, `image-maker`, `startup-script`
and `image-tester`). Other images now have a slighlty more elaborate
regex to account for their "semantic + timestamp + commit sha" new
versioning scheme.

Reference: https://docs.renovatebot.com/modules/versioning/regex/

Note: we're using the `build` capture group for the timestamp element

Note: Renovate requires that all previous capture groups match (even if
with an empty value), this is why the `patch` capture group is
configured to either match the patch version component or match to an
empty value in case the version does not have a patch number (like for
the `checkpatch` and `network-perf` images).

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 2, 2025
@HadrienPatte HadrienPatte marked this pull request as ready for review December 2, 2025 15:02
@HadrienPatte HadrienPatte requested review from a team as code owners December 2, 2025 15:02
@HadrienPatte HadrienPatte requested a review from Artyop December 2, 2025 15:02
@HadrienPatte
Copy link
Copy Markdown
Member Author

/test

@julianwiedmann julianwiedmann added release-note/ci This PR makes changes to the CI. area/build Anything to do with the build, more general than area/CI dependencies Pull requests that update a dependency file and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 2, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 7b20bf3 Dec 2, 2025
84 checks passed
@julianwiedmann julianwiedmann deleted the pr/HadrienPatte/image-tools-renovate branch December 2, 2025 15:31
HadrienPatte added a commit that referenced this pull request Dec 2, 2025
Fixes #43091

Related PR #43087:
> Note: Renovate requires that all previous capture groups match (even if with an empty value), this is why the patch capture group is configured to either match the patch version component or match to an empty value in case the version does not have a patch number (like for the checkpatch and network-perf images).

I did test that initial PR on mend-hosted renovate, but it looks like cilium's
self-hosted flavor does not like that config. To solve the issue here I split
the images that have a patch component in their version from the ones
that don't in two separate groups with their own regex.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte added a commit that referenced this pull request Dec 2, 2025
Fixes #43091

Related PR #43087:
> Note: Renovate requires that all previous capture groups match (even if with an empty value), this is why the patch capture group is configured to either match the patch version component or match to an empty value in case the version does not have a patch number (like for the checkpatch and network-perf images).

I did test that initial PR on mend-hosted renovate, but it looks like cilium's
self-hosted flavor does not like that config. To solve the issue here I split
the images that have a patch component in their version from the ones
that don't in two separate groups with their own regex.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
Fixes #43091

Related PR #43087:
> Note: Renovate requires that all previous capture groups match (even if with an empty value), this is why the patch capture group is configured to either match the patch version component or match to an empty value in case the version does not have a patch number (like for the checkpatch and network-perf images).

I did test that initial PR on mend-hosted renovate, but it looks like cilium's
self-hosted flavor does not like that config. To solve the issue here I split
the images that have a patch component in their version from the ones
that don't in two separate groups with their own regex.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte added a commit that referenced this pull request Dec 2, 2025
Update those images to their latest version following their new
versioning scheme (see cilium/image-tools#413).
Followup updates for those images will be handled by renovate (see #43087).

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte added a commit that referenced this pull request Dec 10, 2025
Update those images to their latest version following their new
versioning scheme (see cilium/image-tools#413).
Followup updates for those images will be handled by renovate (see #43087).

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2025
Update those images to their latest version following their new
versioning scheme (see cilium/image-tools#413).
Followup updates for those images will be handled by renovate (see #43087).

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Anything to do with the build, more general than area/CI dependencies Pull requests that update a dependency file release-note/ci This PR makes changes to the CI.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

3 participants