Skip to content

bpf: Migrate CLUSTER_ID_MAX to runtime config#42478

Merged
ti-mo merged 2 commits intomainfrom
pr/vk/bpf/cluster_id_max/cfg
Dec 18, 2025
Merged

bpf: Migrate CLUSTER_ID_MAX to runtime config#42478
ti-mo merged 2 commits intomainfrom
pr/vk/bpf/cluster_id_max/cfg

Conversation

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

@viktor-kurchenko viktor-kurchenko commented Oct 29, 2025

Migrate CLUSTER_ID_MAX to runtime config.

Related: #38370

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 29, 2025
@viktor-kurchenko viktor-kurchenko changed the title bpf: Migrate VTEP_MASK to runtime config bpf: Migrate CLUSTER_ID_MAX to runtime config Oct 29, 2025
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from f3f869f to ff94700 Compare October 29, 2025 17:02
@viktor-kurchenko viktor-kurchenko added area/loader Impacts the loading of BPF programs into the kernel. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Oct 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 29, 2025
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch 5 times, most recently from 55cd5bd to b49ac70 Compare November 3, 2025 18:11
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from b49ac70 to 8ce2cd4 Compare November 6, 2025 08:57
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

blocked by #43021

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from 8ce2cd4 to f2bf143 Compare December 12, 2025 15:57
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review December 12, 2025 15:58
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners December 12, 2025 15:58
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from f2bf143 to de73cbf Compare December 12, 2025 16:00
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

I think that CLUSTER_ID_MAX is not a node config, because it's not used widely.
But even after clustermesh dependencies refactoring still a lot of configs were modified after running make generate-bpf command in this PR.

cc: @ti-mo

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from de73cbf to b475fcf Compare December 12, 2025 16:11
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from b475fcf to 6d7b561 Compare December 12, 2025 16:26
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

Copy link
Copy Markdown
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few nits.

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from 6d7b561 to 7ec209b Compare December 16, 2025 19:11
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from 7ec209b to 33fddd7 Compare December 16, 2025 20:08
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from 33fddd7 to 63d43ed Compare December 17, 2025 13:17
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

The `CLUSTER_ID_MAX` has been migrated to runtime configuration.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
The valid values for `cluster_id_max` property are: 255 and 511.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cluster_id_max/cfg branch from 63d43ed to a61f9cc Compare December 17, 2025 13:29
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo ti-mo enabled auto-merge December 18, 2025 08:23
@ti-mo ti-mo added this pull request to the merge queue Dec 18, 2025
@julianwiedmann julianwiedmann added the area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Dec 18, 2025
Merged via the queue into main with commit 75e9153 Dec 18, 2025
399 of 409 checks passed
@ti-mo ti-mo deleted the pr/vk/bpf/cluster_id_max/cfg branch December 18, 2025 09:02
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

4 participants