Skip to content

bpf: decouple clustermesh dependencies#43021

Merged
julianwiedmann merged 3 commits intomainfrom
pr/vk/identity/deps
Dec 12, 2025
Merged

bpf: decouple clustermesh dependencies#43021
julianwiedmann merged 3 commits intomainfrom
pr/vk/identity/deps

Conversation

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

Please see description per commit.

@viktor-kurchenko viktor-kurchenko added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Nov 28, 2025
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review November 28, 2025 15:59
@viktor-kurchenko viktor-kurchenko requested a review from a team as a code owner November 28, 2025 15:59
@viktor-kurchenko viktor-kurchenko marked this pull request as draft November 28, 2025 16:14
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/identity/deps branch 2 times, most recently from 88fe811 to 169833b Compare November 28, 2025 20:42
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review November 28, 2025 20:48
@julianwiedmann
Copy link
Copy Markdown
Member

fwiw, I'd want to see #43159 (comment) addressed before we merge this refactor (in case that issue results in a backport-worthy fix)

@julianwiedmann
Copy link
Copy Markdown
Member

fwiw, I'd want to see #43159 (comment) addressed before we merge this refactor (in case that issue results in a backport-worthy fix)

This is #43258.

The commit removes clustermesh dependencies from the overloadable_skb
header by moving identity and clustermesh related functions into
identity and clustermesh header files accordingly.

This is needed in the scope of `clang-free` initiative to avoid
generated config pollution by unused fields.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
The `get_max_identity` function moved into the `__CLUSTERMESH_HELPERS__`
section because only code in the section refers to it.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
The `set_identity_mark` function moved into the identity header.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

This is #43258.

Rebased, thanks!

@julianwiedmann julianwiedmann added the area/clustermesh Relates to multi-cluster routing functionality in Cilium. label Dec 12, 2025
Copy link
Copy Markdown
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

@gentoo-root kind ping)

@julianwiedmann julianwiedmann added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 586062c Dec 12, 2025
346 checks passed
@julianwiedmann julianwiedmann deleted the pr/vk/identity/deps branch December 12, 2025 14:16
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

3 participants