Merged
Conversation
Member
Author
|
/test |
3c030c3 to
3d9f352
Compare
Member
|
/test |
aanm
approved these changes
Aug 25, 2025
The `image-tools` CI is supposed to only build an image if there isn't already a tag for the last commit that changed that image directory on quay.io. There seem to have been an issue with this check in [this job](https://github.com/cilium/image-tools/actions/runs/17178799757/job/48738420427) for the `checkpatch` image causing the job to fail to check for the existing tag, assume it didn't exist and proceed to rebuild it: > /usr/local/bin/crane > 2025/08/23 18:59:33 HEAD request failed, falling back on GET: error getting credentials - err: exit status 1, out: `ANY_REGISTRY_USERNAME is not set` > Error: error getting credentials - err: exit status 1, out: `ANY_REGISTRY_USERNAME is not set` > error: crane returned 1 > quay.io/cilium/cilium-checkpatch:1755701578-b97bd7a doesn't exist With the `1755701578-b97bd7a` tag rebuilt and repushed, quay.io must have garbage collected the previous image digest with the same tag, causing pulls of the previous digest for that tag to start failing ([example](https://github.com/cilium/cilium/actions/runs/17182063773/job/48745850927?pr=41345#step:3:16)): > docker: Error response from daemon: manifest for quay.io/cilium/cilium-checkpatch@sha256:edc094e3c306bbf9b9481f5a99aa6e8e00539cd1f4f7f7f4ffefeeabb0ff88b5 not found: manifest unknown: manifest unknown Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
3d9f352 to
6640a0d
Compare
Member
Author
|
/test |
Member
Author
|
Not sure why @cilium/loader was tagged as codeowner but no individual got assigned by the round-robin logic |
dylandreimerink
approved these changes
Aug 25, 2025
Member
|
@HadrienPatte 👋 given that #41290 is being backported to the various stable branches, do we need to backport this fix as well? I'm seeing the same error in a v1.16 PR. (fyi @giorio94 ) |
Member
Author
|
@julianwiedmann ah yes indeed, this PR will need to be backported to all branches where #41290 has been backported since the image sha in that PR no longer exists |
3 tasks
18 tasks
HadrienPatte
added a commit
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
HadrienPatte
added a commit
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
joestringer
pushed a commit
that referenced
this pull request
Sep 16, 2025
This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 22, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Oct 6, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
[ upstream commit 3642fc4 ] This PR does the same thing as #41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
nddq
pushed a commit
to nddq/cilium
that referenced
this pull request
Feb 17, 2026
[ upstream commit 3642fc4 ] This PR does the same thing as cilium#41360. The initial issue has been resolved with cilium/image-tools#386 but other PRs (cilium/image-tools#387 and cilium/image-tools#383) have been merged before the fix PR, causing the issue to happen again. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More details in cilium/image-tools#385
The
image-toolsCI is supposed to only build an image if there isn't already a tag for the last commit that changed that image directory on quay.io.There seems to have been an issue with this check in this job for the
checkpatchimage causing the job to fail to check for the existing tag, assume it didn't exist and proceed to rebuild it:With the
1755701578-b97bd7atag rebuilt and repushed, quay.io must have garbage collected the previous image digest with the same tag, causing pulls of the previous digest for that tag to start failing (example):