lbipam: do not reallocate IPs on operator restart#41147
Merged
Conversation
9520435 to
d6d6a16
Compare
If there was a pool that was filled and had unsatisfied Services, on operator restart there was a high chance that we will reshuffle assignement of IPs for that pool. This resulted in previously safisfied services to either become unsatisfied or get a new IP. Issue is fixed by not performing any operation on services until full sync happens. After that, first we try to reuse IPs for already satisfied services and only after that we try to assign additional IPs to unsatisfied services. Additionally, add test that covers this case, simulating restart of operator. Related: #40358 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
d6d6a16 to
31ce600
Compare
Member
Author
|
Fixed golang lint + rebased on main |
Member
Author
|
/test |
Member
Author
|
Gateway API seems to be failing quite a lot after rebasing, open related issue: #41150 |
joamaki
approved these changes
Aug 14, 2025
3 tasks
3 tasks
3 tasks
terassyi
pushed a commit
to cybozu-go/cilium
that referenced
this pull request
Dec 12, 2025
lbipam: do not reallocate IPs on operator restart If there was a pool that was filled and had unsatisfied Services, on operator restart there was a high chance that we will reshuffle assignement of IPs for that pool. This resulted in previously safisfied services to either become unsatisfied or get a new IP. Issue is fixed by not performing any operation on services until full sync happens. After that, first we try to reuse IPs for already satisfied services and only after that we try to assign additional IPs to unsatisfied services. Additionally, add test that covers this case, simulating restart of operator. Related: cilium#40358 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
terassyi
added a commit
to cybozu-go/cilium
that referenced
this pull request
Dec 12, 2025
* backport cilium/pull/41122 Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp> * backport cilium/pull/41147 lbipam: do not reallocate IPs on operator restart If there was a pool that was filled and had unsatisfied Services, on operator restart there was a high chance that we will reshuffle assignement of IPs for that pool. This resulted in previously safisfied services to either become unsatisfied or get a new IP. Issue is fixed by not performing any operation on services until full sync happens. After that, first we try to reuse IPs for already satisfied services and only after that we try to assign additional IPs to unsatisfied services. Additionally, add test that covers this case, simulating restart of operator. Related: cilium#40358 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> --------- Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp> Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Co-authored-by: Marcel Zieba <marcel.zieba@isovalent.com>
yokaze
pushed a commit
to cybozu-go/cilium
that referenced
this pull request
Jan 30, 2026
* backport cilium/pull/41122 Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp> * backport cilium/pull/41147 lbipam: do not reallocate IPs on operator restart If there was a pool that was filled and had unsatisfied Services, on operator restart there was a high chance that we will reshuffle assignement of IPs for that pool. This resulted in previously safisfied services to either become unsatisfied or get a new IP. Issue is fixed by not performing any operation on services until full sync happens. After that, first we try to reuse IPs for already satisfied services and only after that we try to assign additional IPs to unsatisfied services. Additionally, add test that covers this case, simulating restart of operator. Related: cilium#40358 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> --------- Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp> Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Co-authored-by: Marcel Zieba <marcel.zieba@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there was a pool that was filled and had unsatisfied Services, on
operator restart there was a high chance that we will reshuffle
assignement of IPs for that pool. This resulted in previously safisfied
services to either become unsatisfied or get a new IP.
Issue is fixed by not performing any operation on services until full
sync happens. After that, first we try to reuse IPs for already
satisfied services and only after that we try to assign additional IPs
to unsatisfied services.
Additionally, add test that covers this case, simulating restart of
operator.
Related: #40358
Depends on: #41122